Log In - Home Page

CommitFest 2012-01 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 66, Returned with Feedback: 31, Rejected: 4. Total: 101.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Index based regexp search for pg_trgm
Patch by smagen on 2011-12-01: Initial version.
Comment by heikki on 2012-01-19: Multibyte-support needs to be fixed. Needs comments.
Returned with Feedback Alexander Korotkov Heikki Linnakangas 2012-01-19
Allow toast tables to be moved to a different tablespace
Comment by gsmith on 2011-12-15: No clear solutions for CLUSTER issue raised. Would like some more info on use case too.
Patch by julmon on 2012-01-23: New version
Comment by rhaas on 2012-01-26: this might be good for something, but we don't know what it is, so marking Returned with Feedback
Returned with Feedback Julien Tachoires Jaime Casanova 2012-01-26
Reduce locking on StrategySyncStart()
Patch by simon on 2012-01-08: Initial version.
Review by heikki on 2012-01-20: Needs performance testing
Comment by rhaas on 2012-01-26: I believe that both of the patches on this thread are off the table for 9.2.
Returned with Feedback Simon Riggs Heikki Linnakangas, Robert Haas 2012-01-26
libpq in android
Patch by alvherre on 2011-11-24: Initial version.
Comment by petere on 2012-01-11: Alternative approach suggested
Comment by rhaas on 2012-01-27: no update on this in months, so marking Returned with Feedback
Returned with Feedback Marco Bernasocchi Nobody 2012-01-27
Background cleaning of CLOG LRU
Patch by simon on 2012-01-12: Initial version. v2 now available on same thread.
Comment by jjanes on 2012-01-28: v2 no longer applies
Returned with Feedback Simon Riggs Nobody 2012-02-01
Add minor version to v3 protocol / Optimize array binary encoding
Comment by rhaas on 2012-02-03: mmconcure: Don't use a GUC.
Comment by rhaas on 2012-02-03: marko kreen: Don't use a GUC.
Comment by rhaas on 2012-02-03: Seems we need better negotiation capabilities before entertaining this.
Returned with Feedback Mikko Tiihonen Noah Misch 2012-02-03
Core extensions relocation
Comment by aglio on 2011-12-07: Stalled pending response from -packagers.
Comment by aglio on 2011-12-09: Awaiting dependency check by author.
Comment by rhaas on 2012-02-03: no real update on this in >2 months
Returned with Feedback Greg Smith Josh Berkus 2012-02-03
Vacuum rate limit in KBps
Patch by gsmith on 2012-01-15: Initial version.
Review by jjanes on 2012-02-04: Overflow and underflow bugs.
Questioning the design of the primary use-facing knob and the docs explanation of it. More minor questioning of the rest of the knobs as well
Returned with Feedback Greg Smith Jeff Janes 2012-02-09
Double Write
Comment by heikki on 2012-01-17: Needs performance testing.
Patch by rhaas on 2012-02-03: A new version from Dan.
Review by rhaas on 2012-02-03: Tiny double-write buffer KO's performance.
Returned with Feedback Dan Scales Heikki Linnakangas, Robert Haas 2012-02-17
pgbench post-connection command
Patch by gsmith on 2012-01-15: Initial version.
Comment by gsmith on 2012-01-15: Suggestions for an updated specification
Returned with Feedback Simon Riggs Nobody 2012-02-22
Measuring relation free space
Review by nmisch on 2012-01-26: More detail regarding the way forward
Patch by jcasanov on 2012-02-14: Patch splited in three parts: pgstattuple improvements, relation_free_space() function and relation_free_space() function with a stats_target parameter
Review by nmisch on 2012-02-22: pgstattuple use of BAS_BULKREAD is Ready for Committer, everything else needs significant work
Returned with Feedback Jaime Casanova, Greg Smith Noah Misch 2012-02-22
Sort memory usage WIP
Review by umitanuki on 2012-02-09: First review. Some questions.
Comment by jjanes on 2012-02-13: More explanation of the nature of the inefficiency this fixes.
Performance numbers over a broader range of mem sizes.
Review by umitanuki on 2012-02-23: It is still under investigation if it's worth doing.
Returned with Feedback Jeff Janes Hitoshi Harada 2012-02-23
Commit Log History Cache
Comment by simon on 2012-02-25: v4 patch sent, test conditions described to allow reasonable testing - patch is intended for real world benefit and will show zero benefit from standard pgbench
Review by rhaas on 2012-02-28: tested patch under requested conditions; large regression at scale factor 300; not sure why
Comment by rhaas on 2012-02-28: Simon will work on this more for a future release
Returned with Feedback Simon Riggs Jeff Janes, Robert Haas 2012-02-28
pgbench option to help measure Clog Contention
Patch by simon on 2012-01-12: v1
Comment by ams on 2012-01-26: Works as advertised (but rhaas said he would tweak further)
Review by rhaas on 2012-02-17: further review, suggestions
Returned with Feedback Simon Riggs Abhijit Menon-Sen 2012-02-28
Reduce freelist locking during DROP TABLE/DROP DATABASE
Patch by simon on 2012-01-08: Initial version.
Patch by simon on 2012-01-08: Choice of 2 patches: 2nd one is removebufmgrfreelist.v2.patch
Returned with Feedback Simon Riggs Nobody 2012-03-05
Page Checksums
Patch by nmisch on 2012-02-21: v10
Comment by jjanes on 2012-03-04: Does not pass "make installcheck" with wal_level above minimal
Comment by rhaas on 2012-03-07: bumped to 9.3
Returned with Feedback Simon Riggs Noah Misch, Robert Haas 2012-03-07
Inline Extension
Comment by heikki on 2012-01-19: This feature doesn't seem like something we want.
Comment by dim on 2012-02-13: We agreed on the feature contents despite the proposal was somewhat misguided. We'll reuse the internals (filesystem based) and allow filling the files from SQL commands. See rest of the threads for detailed design around pg_dump etc.
Comment by rhaas on 2012-03-08: Major redesign, no new patch, marking returned with feedback.
Returned with Feedback Dimitri Fontaine Heikki Linnakangas 2012-03-08
WAL Restore process
Patch by MasaoFujii on 2012-01-25: v3
Review by MasaoFujii on 2012-01-26: Found some minor problems.
Comment by simon on 2012-03-09: Lower priority than other patches, removed from queue for this release
Returned with Feedback Simon Riggs Fujii Masao 2012-03-09
pg_stat_recovery view
Patch by jcasanov on 2012-01-15: Initial version.
Comment by MasaoFujii on 2012-02-13: Do we really need/want to send recovery info through the stats collector?
Short description for each WAL record is not required?
How large the performance regression is if track_recovery is activated?
Shouldn't track_recovery be treated like all the other debug options as a DEVELOPER_OPTION?
Comment by MasaoFujii on 2012-03-10: ping
Returned with Feedback Jaime Casanova Bernd Helmle, Fujii Masao 2012-03-15
Pre-flight and Post-flight logging hooks
Patch by gsmith on 2012-01-16: Initial version.
Comment by tgl on 2012-03-06: Martin Pihlak's now-committed patch grew out of this same thread. Are we still interested in this one?
Comment by rhaas on 2012-03-09: ping
Returned with Feedback Theo Schlossnagle Nobody 2012-03-15
Client Messages
Patch by MasaoFujii on 2012-01-24: Updated version of the patch
Comment by MasaoFujii on 2012-03-01: Needs to solve encoding problem
Comment by rhaas on 2012-03-08: ping
Returned with Feedback Jim Mlodgenski Heikki Linnakangas 2012-03-15
Scaling XLogInsert
Review by MasaoFujii on 2012-02-21: I think it's better to separate the patch into some self-contained patches.
Patch by MasaoFujii on 2012-03-06: New version of the patch
Patch by MasaoFujii on 2012-03-09: New version of the patch
Returned with Feedback Heikki Linnakangas Jeff Janes, Fujii Masao 2012-03-21
checkpoint writeback via sync_file_range
Patch by rhaas on 2012-01-11: Initial version.
Returned with Feedback Robert Haas Greg Smith 2012-03-26
Checkpoint sync pause
Patch by gsmith on 2012-01-16: Initial version.
Returned with Feedback Greg Smith, Simon Riggs Nobody 2012-03-26
PL/pgSQL return value in after triggers
Patch by petere on 2012-01-15: Initial version.
Comment by okbobcz on 2012-01-24: I would reject this patch
Review by rhaas on 2012-03-28: I think it's important not to change the BEFORE trigger case.
Returned with Feedback Peter Eisentraut Pavel Stehule 2012-03-28
Finer Extension dependencies
Patch by rhaas on 2012-03-28: v5 patch from Dimitri
Review by rhaas on 2012-03-28: big picture questions
Comment by rhaas on 2012-04-05: Insufficient consensus to commit this.
Returned with Feedback Dimitri Fontaine Hitoshi Harada, Robert Haas 2012-04-05
Caching constant stable expressions per execution
Patch by intgr on 2012-03-10: Split out patch to refactor current code.
Comment by tgl on 2012-03-23: Refactoring patch is committed, now need a rebase of the caching patch.
Comment by rhaas on 2012-04-05: no updated patch; marking Returned with Feedback
Returned with Feedback Marti Raudsepp Jaime Casanova 2012-04-05
Command Triggers
Review by thom on 2012-03-15: Review of patch v16 with incremental patch to fix various doc issues.
Patch by dim on 2012-03-19: Patch v17, with support completed for all core PLs
Patch by dim on 2012-03-20: Patch v18, with support for CREATE TABLE AS and SELECT INTO
Returned with Feedback Dimitri Fontaine Robert Haas, Thom Brown, Andres Freund 2012-04-05
FOR KEY SHARE foreign keys
Patch by alvherre on 2012-02-14: updated to fix most of the outstanding issues
Comment by nmisch on 2012-02-22: Still needs pg_upgrade support; massive code churn since last reviewed version
Patch by alvherre on 2012-03-18: version 11 -- includes required pg_upgrade support
Returned with Feedback Álvaro Herrera Noah Misch, Simon Riggs 2012-04-06
Keepalive files
Patch by intgr on 2012-02-27: Actual patch
Review by jjanes on 2012-03-04: Needs docs. Not clear what this does, from a user perspective.
Comment by rhaas on 2012-03-28: ping
Returned with Feedback Simon Riggs Jeff Janes 2012-04-06
check function statement
Patch by okbobcz on 2012-03-12: minor cleaning
Patch by okbobcz on 2012-04-02: some reorganization and fixes proposed by Heiki
Patch by okbobcz on 2012-04-17: some minor cleaning
Returned with Feedback Pavel Stehule Petr Jelinek, Albe Laurenz 2012-04-10