Log In - Home Page

CommitFest 2012-01 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Committed".

Status Summary. Committed: 66, Returned with Feedback: 31, Rejected: 4. Total: 101.

Committed Patches

Patch Name Status Author Reviewers Date Closed
pg_test_fsync: Delete temporary file when aborted by a signal
Patch by intgr on 2011-12-07: Initial version.
Committed Marti Raudsepp Robert Haas 2011-12-09
Mingw-w64 32 bit support
Patch by tomoaki on 2011-11-26: Initial version.
Comment by tomoaki on 2011-11-26: comment on the way to patch
Patch by tomoaki on 2011-11-26: revised patch; needs test verify on other windows platform.
Committed Lars Kanis Nishiyama Tomoaki 2011-12-10
Enhance spinlock on power pc architecture
Patch by ishii on 2011-12-28: Initial version.
Committed Manabu Ori Nobody 2012-01-02
Reduce SnapshotData to one cacheline to improve performance of GetSnapshotData
Patch by andresfreund on 2011-11-29: Initial version.
Review by andresfreund on 2011-11-29: some performance results
Review by rhaas on 2011-12-13: Can't measure a performance benefit, but it does save on memory, so seems worth doing.
Committed Andres Freund Robert Haas 2012-01-07
Give superusers inherent replication permission
Patch by nmisch on 2012-01-03: Initial version.
Committed Noah Misch Nobody 2012-01-14
Allow users to kill their own queries
Patch by mha on 2012-01-02: New version of the patch, with questions about NLS integration for someone who knows that stuff.
Comment by gsmith on 2012-01-13: Suggestions on how translation will happen here.
Comment by gsmith on 2012-01-13: Refactoring idea for better translation
Committed Josh Kupershmidt, Edward Muller, Greg Smith Magnus Hagander 2012-01-15
Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers
Patch by rhaas on 2012-01-13: Initial version.
Committed Robert Haas Hitoshi Harada 2012-01-16
fatal flex error in guc-file.l kills the postmaster
Patch by nmisch on 2011-12-31: Initial version.
Review by rhaas on 2012-01-17: coding style nits
Patch by nmisch on 2012-01-17: Nits redone
Committed Noah Misch Robert Haas 2012-01-18
Separate pg_stat_activity current_query into state and query columns
Patch by gsmith on 2012-01-13: Initial version.
Patch by smead on 2012-01-17: V5 fixes the 'backward-diff' of v4 and updates the 'rules' regression test for the pg_stat_replication change (procpid ==> pid )
Committed Scott Mead Magnus Hagander, Greg Smith 2012-01-19
Bitwise operators for macaddr type
Patch by direvus on 2011-12-13: Initial version.
Patch by MasaoFujii on 2012-01-17: Updated version of the patch.
Committed Brendan Jurd Fujii Masao 2012-01-19
Improve relation size functions such as pg_relation_size() to avoid producing an error when called against a no longer visible relation
Patch by phils on 2011-12-21: Initial version.
Patch by phils on 2011-12-22: This is an updated patch based on feedback.
Patch by phils on 2011-12-23: This makes pg_database_size() and pg_tablespace_size() behave similarly
Committed Phil Sorber Robert Haas 2012-01-19
triggered_change_notification
Patch by kgrittn on 2012-01-16: Initial version.
Committed Kevin Grittner Alvaro Herrera, Robert Haas 2012-01-20
psql tab completion for GRANT role
Patch by petere on 2012-01-11: Initial version.
Review by okbobcz on 2012-01-17: it is ready for commit
Committed Peter Eisentraut Pavel Stehule 2012-01-21
ALTER TABLE IF EXISTS
Patch by okbobcz on 2012-01-03: Initial version.
Patch by okbobcz on 2012-01-04: enhanced - ALTER TABLE, VIEW, SEQUENCE, INDEX
Committed Pavel Stehule Simon Riggs 2012-01-23
New replication mode
Patch by MasaoFujii on 2012-01-13: Initial version.
Patch by MasaoFujii on 2012-01-16: Add the APPLY mode per Simon's comment.
Comment by simon on 2012-01-24: APPLY mode too much to handle for this release
Committed Fujii Masao Simon Riggs 2012-01-24
Standby-only backup using pg_basebackup
Patch by MasaoFujii on 2012-01-17: Updated version of the patch.
Review by ssinger on 2012-01-20: Review: looking good, but I encountered an issue in testing I've so far been unable to reproduce
Comment by simon on 2012-01-25: Forgot to thank Steve Singer on patch commit. Many thanks and apologies
Committed Fujii Masao Steve Singer 2012-01-25
psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings
Patch by nmisch on 2012-01-14: Initial version.
Committed Noah Misch Álvaro Herrera 2012-01-25
Second thoughts on CheckIndexCompatible() vs. operator families
Patch by nmisch on 2012-01-07: Initial version.
Patch by nmisch on 2012-01-22: v2 - fix test case
Committed Noah Misch Robert Haas 2012-01-25
pg_trigger_depth() (was TG_DEPTH)
Patch by kgrittn on 2012-01-15: Initial version.
Committed Kevin Grittner Álvaro Herrera 2012-01-25
BGWriter latch/powersaving
Patch by sternocera on 2012-01-17: Initial version.
Patch by alvherre on 2012-01-25: latest version from Heikki
Committed Peter Geoghegan Heikki Linnakangas 2012-01-26
tracking temporary files in pg_stat_database
Patch by fuzzycz on 2011-12-20: Initial version (including docs).
Patch by fuzzycz on 2012-01-17: Fixed failing regression test.
Review by okbobcz on 2012-01-19: there are no problem
Committed Tomas Vondra Pavel Stehule 2012-01-26
show Heap Fetches in EXPLAIN ANALYZE output for index-only scans
Patch by rhaas on 2012-01-13: Initial version.
Review by jjanes on 2012-01-22: Some minor nitpicking
Committed Robert Haas Jeff Janes 2012-01-26
Deadlock counter in pg_stat_database
Patch by mha on 2012-01-16: Initial version.
Comment by jcasanov on 2012-01-24: Initial review. Biggest problem is that pg_stat_reset() doesn't reset deadlock counter
Committed Magnus Hagander Jaime Casanova 2012-01-26
teach information schema/aclexplode about default privileges
Patch by petere on 2012-01-11: Initial version.
Review by ams on 2012-01-26: Looks fine.
Committed Peter Eisentraut Abhijit Menon-Sen 2012-01-27
PL/Python result metadata
Patch by petere on 2012-01-11: Initial version.
Review by ams on 2012-01-26: Looks fine.
Committed Peter Eisentraut Abhijit Menon-Sen 2012-01-30
use plpgsql's function signature instead name in CONTEXT field
Patch by okbobcz on 2011-11-26: Initial version.
Review by ams on 2012-01-26: Earlier patch incomplete. New patch attached.
Patch by okbobcz on 2012-01-28: fix for inline blocks - initialize fn_signature
Committed Pavel Stehule Abhijit Menon-Sen 2012-01-31
Dry-run mode for pg_archivecleanup
Patch by gbartolini on 2011-12-11: Initial version.
Review by schmiddy on 2012-01-15: suggestions about output
Patch by gbartolini on 2012-01-31: Version 2 which adds debug information to stderr and keeps just the filename as output
Committed Gabriele Bartolini Josh Kupershmidt 2012-02-01
separate initdb -A options for local and host
Patch by petere on 2012-01-15: Initial version.
Review by rhaas on 2012-01-16: Looks fine.
Review by miracee on 2012-01-17: Patch looks ok to me - but - we should not make same mistakes in docs twice.
in initdb.sgml:

You start a sentence with the word "Trust".
Unfortunately, this let some users think that you can use a capital T in pg_hba.conf.

It would be better when we take care that "trust" always is written in lower letters. That makes more clear that pg_hba.conf is case sensitive.
Committed Peter Eisentraut Pavel Stehule, Robert Haas, Susanne Ebrecht 2012-02-01
Group commit
Patch by jjanes on 2012-01-28: A newer patch
Comment by sternocera on 2012-01-30: Revision of original patch will follow soon, per Simon.
Comment by simon on 2012-02-01: Additional patch required since committed version didn't cover the case of power reducing latches for WALwriter.
Committed Simon Riggs, Peter Geoghegan Heikki Linnakangas 2012-02-01
Fix float8 parsing of denormal values (on some platforms?)
Patch by intgr on 2011-12-22: Initial version.
Review by doj on 2012-01-13: reviewed the code changes, and they look like they are now correctly checking the return state/value from strtod() function. The patch applies against today's PostreSQL git sources and I've played with some small float numbers and they seem to be parsed/handled correct.
Review by ams on 2012-01-26: Looks fine.
Committed Marti Raudsepp doj(?), Abhijit Menon-Sen 2012-02-01
psql case preserving completion
Patch by petere on 2012-01-11: Initial version.
Review by MasaoFujii on 2012-01-17: Case preserving completion doesn't work expectedly in some cases.
Committed Peter Eisentraut Fujii Masao 2012-02-01
JSON for 9.2
Patch by rhaas on 2012-01-11: Initial version.
Patch by adunstan on 2012-01-15: Updated patch including query_to_json, array_to_json and row_to_json
Review by ams on 2012-01-27: Looks OK in partial review, more comments soon.
Committed Robert Haas, Andrew Dunstan Abhijit Menon-Sen 2012-02-03
Allow SQL-language functions to reference parameters by parameter name
Review by umitanuki on 2012-01-19: Source/tests/doc need a little more work. The basis is ok.
Patch by matthewd on 2012-01-24: v2
Review by umitanuki on 2012-01-26: Everything has been fixed. Seems ok with a minor ambiguity issue.
Committed Matthew Draper Hitoshi Harada 2012-02-05
explain / allow collecting row counts without timing info
Review by erictheise on 2012-01-13: Applied, compiled fine. Failures in "make check".
Patch by fuzzycz on 2012-01-13: Fixed patch. All regression tests should pass now.
Patch by rhaas on 2012-02-03: Updated patch, using EXPLAIN (ROWS) in lieu of EXPLAIN (ANALYZE, TIMING off).
Committed Tomas Vondra Eric Theise 2012-02-07
disable prompting by default in createuser
Patch by petere on 2011-12-22: Initial version.
Review by schmiddy on 2012-01-16: review
Committed Peter Eisentraut Josh Kupershmidt 2012-02-07
Add protransform for numeric, varbit, and temporal types
Patch by nmisch on 2012-01-01: Initial version.
Committed Noah Misch Robert Haas 2012-02-08
Enable min/max optimization for bool_and/bool_or/every
Patch by intgr on 2011-12-19: Initial version.
Review by ams on 2012-01-26: Not much to say. Works perfectly.
Comment by intgr on 2012-02-08: Worst-case overhead benchmark & script
Committed Marti Raudsepp Abhijit Menon-Sen 2012-02-08
psql NUL record and field separator
Patch by petere on 2012-01-15: Initial version.
Review by ams on 2012-01-26: Needs two minor tweaks.
Committed Peter Eisentraut Abhijit Menon-Sen 2012-02-09
LEAKPROOF attribute of FUNCTION
Review by rhaas on 2012-01-25: Needs rebase.
Patch by kaigai on 2012-01-29: Rebased one
Review by rhaas on 2012-02-14: committed; a few open issues
Committed KaiGai Kohei Robert Haas 2012-02-15
Tuplesort fast path sorting
Review by rhaas on 2012-01-26: Committed a few bits; suggest API revision for remainder.
Patch by nmisch on 2012-01-26: Version with btree support removed
Patch by sternocera on 2012-01-27: Revised patch, API updates
Committed Peter Geoghegan Robert Haas 2012-02-15
Improve pretty printing of view definitions
Patch by adunstan on 2011-12-27: Initial version.
Review by umitanuki on 2012-01-13: It's good to go, though we have space to improve.
Committed Andrew Dunstan Hitoshi Harada 2012-02-19
controlling the location of server-side SSL files
Patch by petere on 2012-01-14: Initial version.
Review by miracee on 2012-01-17: Patch is ok besides one small thing in docs:

In runtime.sgml:
...
must disallow any access to world or group; achieve this by the command
chmod 0600 server.key
...

I fear modern Linux users won't understand chmod 0600.

I would write something like this:
...
achieve this by either the command
chmod 0600 server.key or the command chmod u=rw server.key
Committed Peter Eisentraut Susanne Ebrecht 2012-02-22
Make pgBufferUsage track dirty buffers
Review by MasaoFujii on 2012-02-20: Three comments.
Review by gsmith on 2012-02-22: Review test samples
Review by gsmith on 2012-02-22: How should old versions of the extension be handled?
Committed Robert Haas Greg Smith, Fujii Masao 2012-02-23
Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE
Comment by jjanes on 2012-01-22: Does not pass make check
Patch by nmisch on 2012-01-22: v3
Patch by nmisch on 2012-01-26: v4 - rebase and improve a comment
Committed Noah Misch Dimitri Fontaine 2012-02-27
psql filename completion: quoting
Patch by nmisch on 2012-01-14: Initial version.
Review by pvh on 2012-02-23: Works for me.
Committed Noah Misch Royce Ausburn 2012-02-28
Move CRC tables to pg_crc.h
Review by ams on 2012-01-26: Looks fine, two bad hunks updated.
Review by tgl on 2012-01-31: Wouldn't it bloat the backend quite a lot to do it this way?
Patch by fdr on 2012-02-23: v3. This revision preventing multiple copies of the tables while making tables available via #include.
Committed Daniel Farina Abhijit Menon-Sen 2012-02-29
collation for (expr)
Review by probabble on 2012-01-13: Could not get patch to compile with gram.y changes.
Patch by jcasanov on 2012-03-01: New version of the patch posted by Peter Eisentraut on Jan 19
Comment by jcasanov on 2012-03-02: The patch works fine after very little fix in the pg_proc entry
Committed Peter Eisentraut Evan Babb, Jaime Casanova 2012-03-02
Alternate psql file locations
Patch by adunstan on 2012-01-01: Initial version.
Review by theory on 2012-02-21: Ready for committer.
Committed Andrew Dunstan David Wheeler 2012-03-03
Collect frequency statistics and selectivity estimation for arrays
Patch by smagen on 2012-01-17: Updated version of a patch. Proof of some concepts is still needed.
Patch by smagen on 2012-01-22: Path with more detailed description of undelying concepts.
Patch by nmisch on 2012-01-23: Cosmetic edits to Alexander's v0.12
Committed Alexander Korotkov Noah Misch 2012-03-04
Compute the difference between two XLOG locations
Patch by eulerto on 2012-02-12: Patch fixed segfault.
Review by MasaoFujii on 2012-02-13: Minor comments.
Review by mha on 2012-02-25: Final(?) comments before commit...
Committed Euler Taveira de Oliveira Fujii Masao 2012-03-04
GiST for range types improvements
Patch by jdavis on 2012-01-29: Updated patch.
Review by jdavis on 2012-01-29: Includes minor cleanup patch and test case.
Patch by smagen on 2012-01-30: Comment fixes by Jeff Davis.
Committed Alexander Korotkov Jeff Davis 2012-03-05
logging hooks
Review by intgr on 2012-01-17: A few nitpicks, marking 'Waiting on Author'
Patch by intgr on 2012-01-18: 3rd patch iteration
Comment by intgr on 2012-01-20: Instructions to test patch with pg_logforward
Committed Martin Pihlak Marti Raudsepp 2012-03-06
DROP Permission check of sepgsql
Patch by kaigai on 2012-01-23: Hook moved to deleteOneObject, and a flag added to inform whether user's activity or just internal cleanup
Patch by rhaas on 2012-01-25: extracted just part of KaiGai's patch, and revised it.
Patch by kaigai on 2012-02-05: Revised one
Committed KaiGai Kohei Robert Haas 2012-03-09
renaming constraints
Patch by petere on 2012-01-11: Initial version.
Review by aglio on 2012-01-13: Failure with inherited tables. Needs revision.
Patch by petere on 2012-02-01: new patch
Committed Peter Eisentraut Dimitri Fontaine 2012-03-10
NULLs support in SP-GiST
Comment by rhaas on 2012-03-07: is this a stop-ship item for spgist?
Review by tgl on 2012-03-09: The whole approach seems wrong to me, both as to storage and as to the opclass API change.
Comment by tgl on 2012-03-11: Committed a heavily rewritten version of this.
Committed Teodor Sigaev, Oleg Bartunov Jaime Casanova 2012-03-11
pgstattuple: use BAS_BULKREAD
Patch by nmisch on 2012-03-13: Initial version.
Comment by nmisch on 2012-03-13: This is a committable fragment from original patch https://commitfest.postgresql.org/action/patch_view?id=778
Committed Jaime Casanova Noah Misch 2012-03-13
GUC of sepgsql.client_label
Patch by yhavinga on 2012-03-03: Small changes. Patch still needs documentation.
Patch by kaigai on 2012-03-06: merge some proposition from Yeb
Review by rhaas on 2012-03-09: label handling seems unduly complex; also, needs docs
Committed KaiGai Kohei Yeb Havinga 2012-03-15
Turn CTAS/SELECT INTO into utility commands
Patch by dim on 2012-03-15: Initial version.
Comment by andresfreund on 2012-03-16: Use ctas-01.patch and not ctas-on-command-triggers-01.patch because the command trigger patch changes too fast.
Committed Andres Freund Tom Lane 2012-03-20
pg_stat_statements with query tree based normalization
Comment by tgl on 2012-03-29: Committed, although there are a couple loose ends to try to clean up.
Comment by tgl on 2012-03-29: The only remaining loose end is better management of sticky-entry decay, which doesn't seem terribly critical.
Comment by sternocera on 2012-04-08: Sticky-entry decay is now managed in a well-principled fashion.
Committed Peter Geoghegan Daniel Farina 2012-03-29
Speed dblink using alternate libpq tuple storage
Patch by horiguti on 2012-03-27: Bug fix of the previous dblink patch.
Comment by markokr on 2012-03-30: PQgetRow() API overview
Patch by horiguti on 2012-04-04: Use old way for a async query with dblink_is_busy. Some bugs fixed. And rebased.
Committed Kyotaro Horiguchi Marko Kreen 2012-04-04
Allow pg_archivecleanup to ignore file extensions
Comment by rhaas on 2012-03-08: ping
Patch by jcasanov on 2012-03-09: Patch rebased and with the suggestion implemented
Comment by rhaas on 2012-03-28: ping
Committed Greg Smith, Jaime Casanova Peter Geoghegan 2012-04-05
Publish checkpoint timing and sync files summary data to pg_stat_bgwriter
Patch by gsmith on 2012-01-16: Initial version.
Comment by jjanes on 2012-01-22: initdb fails with OID collisions 3144 to 3146
Review by sternocera on 2012-02-22: Preliminary review
Committed Greg Smith Peter Geoghegan 2012-04-05
Collecting statistics on foreign tables
Comment by hanada on 2012-02-10: Generating statistics without sampling rows requires few functions to be exported.
Patch by hanada on 2012-04-05: v7, some cosmetic changes.
Patch by hanada on 2012-04-06: v8, merge with Fujita-san's v7 patch, and fix memory leak.
Committed Etsuro Fujita Shigeru Hanada 2012-04-06
DROP INDEX CONCURRENTLY
Comment by simon on 2012-02-01: v5 posted, all bugs fixed
Review by rhaas on 2012-02-03: Can't find any more bugs.
Comment by rhaas on 2012-03-28: ping
Committed Simon Riggs Robert Haas 2012-04-06
Add timing of buffer I/O requests
Review by rhaas on 2012-03-21: No longer applies, needs rebase.
Patch by antsaasma on 2012-03-23: Rebased.
Comment by rhaas on 2012-03-28: mostly committed, should we perhaps add some pgstat counters at the db level?
Committed Ants Aasma Greg Smith 2012-04-10
URI connection string support for libpq
Comment by markokr on 2012-03-19: Basic use-case not implemented: PQconnectdb()
Patch by ash on 2012-03-22: v9: fix PQconnectdb usecase; rebase against master.
Patch by ash on 2012-03-27: v10: fix minor issues found by Heikki Linnakangas, use a fix from Peter Eisentraut, update documentation(!) Needs a final (hopefully) review.
Committed Alex Shulgin Greg Smith, Nick Roosevelt, Christopher Maujean, Daniel Farina 2012-04-11