Log In - Home Page

CommitFest 2011-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 31, Returned with Feedback: 20, Rejected: 2. Total: 53.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Adding CORRESPONDING to Set Operations
Comment by keremkat on 2011-10-19: The referenced message is the first message about this topic. This patch is my first submission.
Patch by keremkat on 2011-10-25: (v3) CORRESPONDING BY column ordering changed to match the standard draft 20nn, thanks to Erik Rijkers
Review by umitanuki on 2011-11-17: Quick review comments. Need to rework in design.
Returned with Feedback Kerem KAT Hitoshi Harada 2011-11-22
Comment by rhaas on 2011-11-18: Committed part 1 with minor revisions.
Review by rhaas on 2011-11-18: Not sure parts 2 through 4 are going in the right direction.
Comment by kaigai on 2011-12-01: Another approach may consolidate the code well.
Returned with Feedback KaiGai Kohei Robert Haas 2011-12-01
Foreign keys with arrays
Comment by gbartolini on 2011-11-04: Useful reference: thread started by Peter Eisentraut on hackers
Review by nmisch on 2011-11-17: Various failing test cases, etc.
Comment by gsmith on 2011-12-10: Discussion of feature specification
Returned with Feedback Gabriele Bartolini, Marco Nenciarini Noah Misch 2011-12-10
%TYPE and array declaration
Patch by wmula on 2011-10-23: Initial version.
Review by gsmith on 2011-11-30: Initial review: some bit rot, code suggestions, and concerns over large regression tests.
Comment by gsmith on 2011-12-10: Tom is concerned about the grammar rewrite and overall code impact of the patch.
Returned with Feedback Wojciech Muła Pavel Stehule 2011-12-10
Online base backup from the hot-standby
Patch by Jun Ishizuka on 2011-11-01: Initial version. but this is infrastructure.
Review by ssinger on 2011-11-15: Please post an updated patch with some of the recently committed xlog refactoring merged in
Returned with Feedback Fujii Masao and Jun Ishiduka Steve Singer 2011-12-12
pg_terminate_backend and pg_cancel_backend by not administrator user
Comment by fdr on 2011-11-16: The limited form already posted would still have good value, without extension.
Comment by gsmith on 2011-12-01: More agreement that a simple same-user cancel mechanism is good enough for now.
Comment by pvh on 2011-12-12: Any improvement here will have major operational benefits for non-superuser users who need to be able to forcibly abort in progress statements.
Returned with Feedback Torello Querci Josh Kupershmidt 2011-12-13
Configuration include directory
Review by nmisch on 2011-12-06: Initial review
Patch by gsmith on 2011-12-12: Updated patch to address feedback, add docs.
Review by nmisch on 2011-12-13: Many things now fixed, some remain
Returned with Feedback Magnus Hagander and Greg Smith Noah Misch 2011-12-13
Command Triggers
Comment by gsmith on 2011-12-15: Thoughts on why Command Triggers are not DDL triggers, and the expected scope limit of the approach used.
Comment by gsmith on 2011-12-15: Thoughts on potential Slony use of this feature
Comment by gsmith on 2011-12-15: Suggested improvements for DDL triger like support, followed by descent into ProcessUtility scope.
Returned with Feedback Dimitri Fontaine Andres Freund 2011-12-15
Comment by kgrittn on 2011-12-01: Confirms fixes and clean apply. Note a few more minor issues missed before.
Review by kgrittn on 2011-12-02: Finished review, including extraWaits and related semaphores. Suggested a few micro-optimizations. Could be "Ready for Committer" if we split modularity issue to a separate patch.
Patch by rhaas on 2011-12-15: Updated patch set... but not going to apply this right now.
Returned with Feedback Robert Haas Kevin Grittner 2011-12-15
Separate pg_stat_activity into current_query into state and query columns
Comment by smead on 2011-11-17: query_start column needs consideration now that state / query are broken apart, telling the difference between how long a query has been in the system and how long we've been 'idle in transaction' for.
Patch by smead on 2011-11-19: * Updated documentation
* Updated regression
* Renamed procpid => pid
* Added state_change (timestamp) to follow
the 'state' column
* Fixed minor bugs
- See message for details
Review by mha on 2011-12-06: Another review, requiring some further changes
Returned with Feedback Scott Mead Magnus Hagander, Greg Smith 2011-12-15
Measuring relation free space
Review by jjanes on 2011-11-26: Reported value needs to be a percentage rather than fraction.
Is the behavior correct for non-BTree index?
Comment by gsmith on 2011-12-15: Summary of issues to work on
Comment by gsmith on 2011-12-19: Detailed notes on crossover with pgstattuple
Returned with Feedback Jaime Casanova and Greg Smith Jeff Janes 2011-12-15
Review by laurenz on 2011-12-15: crashes on functions defined with a SET clause
Patch by laurenz on 2011-12-15: new patch without "quiet" option, fix for the crash and improvements for SECURITY DEFINER functions
Review by laurenz on 2011-12-16: Bug if CHECK FUNCTION ALL finds no function, oddness about option "fatal_errors"
Returned with Feedback Pavel Stehule Laurenz Albe 2011-12-16
Comment by tgl on 2011-10-29: Pushing to next commitfest to give time for Simon to give a counterproposal, while not taking this patch off the table.
Review by gsmith on 2011-12-10: Concerns about the accuracy of this data, alternate timestamp driven approach outlined.
Patch by gsmith on 2011-12-15: Alternate implementation using an approach with keepalives from WALsender to WALreceiver.
Returned with Feedback Fujii Masao Kyotaro Horiguchi 2011-12-16
unite recovery.conf and postgresql.conf
Patch by MasaoFujii on 2011-10-11: Updated version
Comment by tgl on 2011-10-29: This is stalled for lack of consensus on how much backwards compatibility we need.
Comment by gsmith on 2011-12-14: Suggestions for a forward path
Returned with Feedback Fujii Masao Nobody 2011-12-16
Tuplesort comparison overhead reduction
Patch by sternocera on 2011-11-23: Added revision of patch
Patch by sternocera on 2011-11-26: Further revision of patch, which manufactures inlining and non-inlining variants
Comment by rhaas on 2011-12-15: Author will rebase.
Returned with Feedback Peter Geoghegan Robert Haas 2011-12-16
GiST for range types improvements
Patch by smagen on 2011-12-02: Rebased with head.
Review by jdavis on 2011-12-12: A few comments and some cleanup.
Patch by gsmith on 2011-12-16: Updated patch with fixes merged
Returned with Feedback Alexander Korotkov Jeff Davis 2011-12-16
Caching constant stable expressions per execution
Patch by gsmith on 2011-12-10: Version 4. Open questions about extending ExecInitExpr.
Patch by gsmith on 2011-12-12: Version 5
Patch by gsmith on 2011-12-16: Performance test case program
Returned with Feedback Marti Raudsepp Jaime Casanova 2011-12-16
Join push-down for foreign tables
Patch by hanada on 2011-11-15: Initial version.
Comment by heikki on 2011-12-02: Ongoing discussion here
Comment by heikki on 2012-01-05: Need to work on the API
Returned with Feedback Shigeru Hanada Heikki Linnakangas 2012-01-05
Collect frequency statistics and selectivity estimation for arrays
Review by nmisch on 2011-12-29: Strategy works, implementation needs refinement
Patch by smagen on 2012-01-09: Revised version of patch
Review by nmisch on 2012-01-12: Close to ready, a few more things to nail down
Returned with Feedback Alexander Korotkov Nathan Boley, Noah Misch 2012-01-12
Allow substitute allocator for PGresult.
Patch by horiguti on 2011-12-08: This is the documentaion.
Review by rhaas on 2011-12-21: A few review comments.
Comment by gsmith on 2012-01-13: Author comments on renaming, PGresAttValue, TupleStore use.
Returned with Feedback Kyotaro Horiguchi Tom Lane 2012-01-14