Log In - Home Page

CommitFest 2011-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Committed".

Status Summary. Committed: 31, Returned with Feedback: 20, Rejected: 2. Total: 53.

Committed Patches

Patch Name Status Author Reviewers Date Closed
PQconnectdbParams keywords and values args "const char *const*"
Patch by lmamane on 2011-09-21: Initial version.
Patch by lmamane on 2011-09-21: Revised patch to use "const char *const * " instead of "char const* const*", as per comments on bug list, and as per existing use in that file for paramValues arg of PQexecParams and friends.
Committed Lionel Elie Mamane Craig Ringer 2011-09-25
Document DELETE/UPDATE command tag vs triggers
Patch by intgr on 2011-09-25: Initial version.
Committed Marti Raudsepp Robert Haas 2011-10-10
EXECUTE tab completion
Patch by doublehyphen on 2011-10-01: Initial version.
Patch by doublehyphen on 2011-10-20: Updated to fit head.
Committed Andreas Karlsson Josh Kupershmidt 2011-10-23
Don't allow join removal for deferrable unique constraints
Patch by intgr on 2011-10-19: Initial version.
Patch by tgl on 2011-10-23: Committed a greatly simplified version, per Robert's comments.
Committed Marti Raudsepp Robert Haas 2011-10-23
Don't treat a superuser as a member of every group for hba.
Patch by adunstan on 2011-11-02: Initial version.
Committed Andrew Dunstan Robert Haas 2011-11-03
remove hstore's =>(text, text)
Patch by rhaas on 2011-11-02: Initial version.
Comment by rhaas on 2011-11-02: Motivation for this change is that the SQL standard defines an incompatible meaning for =>
Committed Robert Haas Dimitri Fontaine, David Wheeler, Tom Lane 2011-11-08
make psql retain blank lines within commands in history
Patch by rhaas on 2011-11-14: Initial version.
Committed Robert Haas Nobody 2011-11-18
Add permission check on SELECT INTO
Patch by kaigai on 2011-11-02: Initial version.
Review by laurenz on 2011-11-18: Error message is bad and probably indicates a code problem. Regression test does not test functionality.
Patch by kaigai on 2011-11-19: Bug fix, and revised test cases
Committed KaiGai Kohei Laurenz Albe 2011-11-22
Out of band storage for PGPROC members
Comment by rhaas on 2011-11-18: Performance test results.
Patch by rhaas on 2011-11-22: New version with more cleanup, and a question about GetSnapshotData().
Comment by kgrittn on 2011-11-24: Some benchmarks on 32-core Intel box.
Committed Pavan Deolasee Heikki Linnakangas, Robert Haas 2011-11-25
Displaying accumulated autovacuum cost
Patch by gsmith on 2011-11-16: Initial version.
Committed Noah Misch and Greg Smith Álvaro Herrera 2011-11-25
plperl verify utf8 strings
Patch by alexhunsaker on 2011-10-07: Initial version.
Review by alexhunsaker on 2011-10-07: review
Committed Alex Hunsaker Amit Khandekar 2011-11-26
Perl xsubpp from cpan
Patch by alexhunsaker on 2011-11-03: Initial version.
Patch by alexhunsaker on 2011-11-03: v3, assorted fixes
Committed David E. Wheeler Alex Hunsaker 2011-11-26
Disable SSL compression
Patch by laurenz on 2011-11-15: Initial version.
Patch by laurenz on 2011-11-17: Fixed a bug and improved documentation.
Comment by mha on 2011-11-28: Committed.
Committed Laurenz Albe Magnus Hagander 2011-11-28
Include detailed information about a row failing a CHECK constraint into the error message
Patch by jkt on 2011-11-09: Initial version.
Patch by jkt on 2011-11-10: Updated patch which trims each printed column to at most 64 characters to prevent huge error messages on tables with big data.
Review by royce on 2011-11-16: Regression tests need updating, some minor comments on the DETAIL line's format. Otherwise good.
Committed Jan Kundrát (jkt) Royce Ausburn 2011-11-29
Make the handling of invalid-page table safer
Patch by MasaoFujii on 2011-10-11: Initial version.
Committed Fujii Masao Heikki Linnakangas 2011-12-02
setenv builtin command for psql
Patch by adunstan on 2011-11-02: Initial version.
Review by schmiddy on 2011-11-21: Review of v2 patch
Patch by adunstan on 2011-11-26: revised patch to deal with reviewer comments.
Committed Andrew Dunstan Josh Kupershmidt 2011-12-04
PL/Python using SPI cursors
Review by ssinger on 2011-11-20: I found a few bugs that need to be addressed.
Patch by wulczer on 2011-11-23: v2 with the bugs hopefully fixed
Review by ssinger on 2011-11-26: Revised version of the patch seems fine
Committed Jan Urbański Steve Singer 2011-12-05
allow src/tools/scripts to work w/no postgres database
Patch by rhaas on 2011-11-13: Initial version.
Review by mha on 2011-12-06: Another review (one or more in the thread before that too)
Committed Robert Haas Bruce Momjian, Magnus Hagander 2011-12-06
Cancel query if the connection is lost
Patch by fgp on 2011-10-17: Initial version.
Comment by fgp on 2011-10-17: Originally meant to prevent a walsender process from lingering indefinitely if archive_mode=on but no archive_command is set (or fails indefinitely) and pg_basebackup is cancelled while it waits for pg_stop_backup() to suceed. The patch is more general than that, though, and cancelles any query if the client connection vanishes. That detection only works if we actually attempt to send something, e.g. a NOTICE, though.
Comment by gregj on 2011-10-19: So I looked at the patch, and first thing that pops out, is lack of the volatile keyword before the ClientConnectionLostPending variable is defined.

I haven't tested the code, just reviewed the patch itself.
Committed Florian Pflug Greg Jaskiewicz, Heikki Linnakangas 2011-12-09
cursor calling with named parameters
Review by kgrittn on 2011-12-03: Overall good. A few minor points to fix.
Patch by yhavinga on 2011-12-11: Added mixed notation.
Review by kgrittn on 2011-12-12: All concerns addressed.
Committed Yeb Havinga Kevin Grittner 2011-12-14
exclude-table-data option for pg_dump
Review by aglio on 2011-11-03: Functional Review
Review by mha on 2011-12-06: Newer review, with comments
Patch by adunstan on 2011-12-12: Documentation updated per comments from rhaas.
Committed Andrew Dunstan Peter Geoghegan 2011-12-14
includeifexists in configuration file
Patch by gsmith on 2011-11-16: Initial version.
Patch by gsmith on 2011-12-15: Updated v2 patch, fixes all open suggestions
Committed Greg Smith Euler Taveira de Oliveira 2011-12-15
type privileges
Review by gsmith on 2011-12-10: Additional review questions
Patch by yhavinga on 2011-12-14: Updated patch
Comment by yhavinga on 2011-12-14: No further major points. smallint vs smallint[] in a permission denied remains todo.
Committed Peter Eisentraut Yeb Havinga 2011-12-16
pg_dump switch --section=pre-data|data|post-data
Review by aglio on 2011-12-07: Functionality review from 11/16
Review by gsmith on 2011-12-10: Code formatting/location suggestions, documentation/usage warning suggestions.
Patch by adunstan on 2011-12-12: Revised patch in response to reviewer comments.
Committed Andrew Dunstan Joachim Wieland 2011-12-16
WIP: SP-GiST, Space-Partitioned GiST
Patch by gsmith on 2011-12-16: Updated patch from Tom. Split off discussion about VACUUM issues.
Comment by gsmith on 2011-12-16: VACUUM discussion started here.
Comment by gsmith on 2011-12-16: Second side discussion about index-only scans
Committed Teodor Sigaev, Oleg Bartunov Tom Lane 2011-12-17
splitting plpython into smaller parts
Patch by wulczer on 2011-11-14: Initial version.
Patch by wulczer on 2011-12-05: Rebased against master after the cursors patch landed.
Committed Jan Urbański Peter Eisentraut 2011-12-18
Non-inheritable check constraints
Comment by Nikhils on 2011-10-08: Alex has provided a rebased patch with some more modifications and cleanup. We both feel that it is "Ready for Committer" now.
Patch by alexhunsaker on 2011-10-09: v3
Review by gsmith on 2011-12-10: Initial committer review, question about implementation
Committed Nikhil Sontakke Alex Hunsaker 2011-12-19
Prep object creation hooks
Patch by kaigai on 2011-11-15: Initial version.
Patch by kaigai on 2011-12-02: Revised patches using ProcessUtility / ExecutorStart hook, instead of new hooks
Patch by gsmith on 2011-12-16: Explanations of DDL permissions on creation time added by these patches, added a few regression test cases.
Committed KaiGai Kohei Dimitri Fontaine 2011-12-21
avoid taking two snapshots per query
Patch by rhaas on 2011-11-14: New version: still reduces simple protocol from 2 snapshots to 1; now also reduces extended protocol from 3 snapshots to 2.
Comment by dim on 2011-11-26: more comments needs adjusting.
Comment by rhaas on 2011-12-15: Update.
Committed Robert Haas Dimitri Fontaine 2011-12-21
Fix Leaky Views Problem, again
Patch by rhaas on 2011-12-07: cleaned-up version
Review by rhaas on 2011-12-08: uh-oh. selectivity estimators are a possible attack vector.
Patch by gsmith on 2011-12-19: Updated v8 with selectivity changes
Committed KaiGai Kohei Robert Haas 2011-12-22
Add Support for building with Visual Studio 2010
Comment by adunstan on 2011-12-09: Waiting on rearrangement of code to make it cleaner and more symmetric.
Patch by brar on 2011-12-27: Updated patch - rearranged code as suggested.
Patch by brar on 2012-01-01: Updated patch - Fixed problems in src/include/port/win32.h that prevented postgres built with VS 2010 from connecting.
Committed Brar Piening Craig Ringer 2012-01-03