Log In - Home Page

CommitFest 2011-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Rejected".

Status Summary. Committed: 30, Returned with Feedback: 16, Rejected: 6. Total: 52.

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Domains over composite types
Patch by heikki on 2011-06-24: Initial version.
Comment by yhavinga on 2011-07-14: The current version needs work: a domain composite type won't work from pl/pgsql.
Rejected Yeb Havinga Yeb Havinga 2011-07-25
Ignore lost+found when checking if a directory is empty
Patch by bdp on 2011-08-09: Initial version.
Comment by rhaas on 2011-09-14: Several votes against doing this, and no votes in favor, so marking rejected.
Rejected Brian Pitts Nobody 2011-09-14
Optimizing pg_trgm makesign()
Comment by kgrittn on 2011-09-26: Tom expresses concern about performance of Heikki's patch on 32-bit systems, and expresses concern about changes to HASH macros.
Review by kgrittn on 2011-09-29: Tom's 1st patch improves on Heikki's first patch. Tom's 2nd patch erases performance gain for actual English text. Heikki's 2nd patch crashes on 32-bit compiles. Can either 2nd patch be salvaged?
Comment by tgl on 2011-10-01: Heikki's later idea (eliminate all the redundant calls of makesign) pretty much obsoletes this idea.
Rejected Heikki Linnakangas Kevin Grittner 2011-10-01
fix pg_dumpall to dump role config and database config at the end of dump
Comment by tgl on 2011-09-04: Before accepting this we need to think about the consequences for settings such as dynamic_library_path.
Review by rhaas on 2011-10-10: Tom's concerns seem valid, but why not just RESET ROLE?
Comment by phils on 2011-10-12: Rejecting my own patch.
Rejected Phil Sorber Nobody 2011-10-10
Object access hook with arguments
Patch by kaigai on 2011-08-28: Initial version.
Patch by kaigai on 2011-09-29: Patch updated
Review by rhaas on 2011-10-12: This approach seems unacceptable.
Rejected KaiGai Kohei Robert Haas 2011-10-12
prepare plans of embedded sql on function start
Comment by tgl on 2011-09-17: I think we'd be better off seeing this as an extension to the capabilities of VALIDATOR functions, and driven by some explicit CHECK request, not automatically during any function call.
Patch by tgl on 2011-10-06: Updated patch using CHECK syntax
Comment by tgl on 2011-10-29: Original approach is considered rejected. New patch requires a new review, so I entered it in 2011-11 commitfest.
Rejected Pavel Stehule Tom Lane 2011-10-29