Log In - Home Page

CommitFest 2011-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 30, Returned with Feedback: 16, Rejected: 6. Total: 52.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
savepoint commit performance
Patch by rhaas on 2011-07-18: Initial version.
Review by AndyColson on 2011-09-06: need update per Heikki
Returned with Feedback Simon Riggs Nobody 2011-09-06
COPY option SKIP_WAL
Patch by ssinger on 2011-08-23: Initial version.
Comment by ssinger on 2011-09-13: Good suggestions from Robert and Alvaro. Will try pursue those ideas but and updated patch won't be ready in time for this commitfest.
Returned with Feedback Steve Singer Nobody 2011-09-13
Collect frequency statistics and selectivity estimation for arrays
Patch by smagen on 2011-06-14: Few more comments and some fixes
Review by aglio on 2011-07-15: Review from Nathan Boley
Comment by rhaas on 2011-09-21: Patch has not been updated in two months; issues from original review not addressed.
Returned with Feedback Alexander Korotkov Nathan Boley 2011-09-21
Cataloguing NOT NULL constraints
Patch by alvherre on 2011-07-22: updated version with pg_dump support and other cleanups
Comment by alvherre on 2011-09-14: Peter thinks this is entirely the wrong approach
Comment by kgrittn on 2011-09-26: Per Álvaro, not ready for review until major rewrite based on Peter's comments.
Returned with Feedback Álvaro Herrera Bernd Helmle 2011-09-26
regular logging of checkpoint progress
Patch by fuzzycz on 2011-09-02: Fixed comment, lower message priority (NOTICE instead of LOG)
Review by gsmith on 2011-09-19: Proposed changes with an enum based setting, making log verbosity more reasonable.
Comment by kgrittn on 2011-09-26: Author says he won't be able to submit reworked patch in time for this CF.
Returned with Feedback Tomas Vondra Greg Smith 2011-09-26
Single pass vacuum
Comment by AndyColson on 2011-09-07: patch needs rebased please
Patch by AndyColson on 2011-09-08: rebased
Review by rhaas on 2011-09-23: Worries about vacuum generation numbers, and MVCC catalog handling.
Returned with Feedback Pavan Deolasee Robert Haas 2011-10-10
Fix Leaky Views
Comment by rhaas on 2011-09-26: compiler warnings, fails regression tests, performance not acceptable
Patch by kaigai on 2011-09-28: Patch updated according to the above suggestions.
Review by rhaas on 2011-10-10: don't think this approach will work
Returned with Feedback KaiGai Kohei Robert Haas 2011-10-10
DROP statement reworks
Review by rhaas on 2011-10-10: compiler warnings
Comment by kaigai on 2011-10-11: Sorry, I didn't write out dependencies of the patches. Please apply in order of part-1, part-2 then part-3.
Review by rhaas on 2011-10-11: committed a few bits of this, rest needs substantial revision
Returned with Feedback KaiGai Kohei Dimitri Fontaine, Robert Haas 2011-10-11
Inserting heap tuples in bulk in COPY
Patch by heikki on 2011-09-14: Initial version.
Review by kaigai on 2011-09-26: review comments about heap_prepare_insert, CheckForSerializableConflictIn and volatile functions
Comment by rhaas on 2011-10-12: no update from author, marking returned with feedback
Returned with Feedback Heikki Linnakangas KaiGai Kohei 2011-10-12
Displaying accumulated autovacuum cost
Review by hanada on 2011-09-26: Basically fine, needs rebase.
Comment by gsmith on 2011-10-03: Should this report even when running non cost-based vacuums?
Comment by rhaas on 2011-10-12: no updated from author, marking returned with feedback
Returned with Feedback Noah Misch and Greg Smith Shigeru Hanada 2011-10-12
psql setenv command
Patch by kgrittn on 2011-09-19: Initial version.
Review by schmiddy on 2011-09-26: needs line in help.c, maybe tweak for WIN32?
Comment by rhaas on 2011-10-12: no update from author, marking returned with feedback
Returned with Feedback Andrew Dunstan Josh Kupershmidt, Jeff Janes 2011-10-12
pg_comments system view
Patch by schmiddy on 2011-09-13: Fix spurious doc change noticed by Thom Brown
Comment by rhaas on 2011-10-12: Do we want this?
Comment by rhaas on 2011-10-17: Apparently not very much.
Returned with Feedback Robert Haas, Josh Kupershmidt Lacey Powers 2011-10-17
WIP: Join push-down for foreign tables
Patch by hanada on 2011-09-15: Initial version.
Comment by kaigai on 2011-10-03: - An interface is necessary to inform the core supported features.
- The known issues might be a problem in pgsql_fdw side, not this patch itself.
Comment by rhaas on 2011-10-24: author will resubmit for next CF
Returned with Feedback Shigeru Hanada KaiGai Kohei 2011-10-24
cursor calling with named parameters
Patch by yhavinga on 2011-10-07: Updated patch
Review by royce on 2011-10-11: Seems good.
Review by tgl on 2011-10-15: Error reporting behavior needs much more work.
Returned with Feedback Yeb Havinga Royce Ausburn 2011-10-24
Online base backup from the hot-standby
Patch by Jun Ishizuka on 2011-10-19: updates to patch (fpw ver 7). change to the logic that fujii has suggested.
Patch by MasaoFujii on 2011-10-24: hopes this is the final version of the patch.
Review by heikki on 2011-10-26: This is too large a footgun. Let's make this work for pg_basebackup first.
Returned with Feedback Jun Ishizuka Steve Singer, Fujii Masao 2011-10-26
%TYPE and array declaration
Review by okbobcz on 2011-10-24: this is ready for commit
Patch by okbobcz on 2011-10-25: final Wojciech's patch,

regress tests are ok, no warnings
Review by tgl on 2011-10-28: I think this implementation is going in entirely the wrong direction.
Returned with Feedback Wojciech Muła <wojciech_mula@poczta.onet.pl> Pavel Stehule 2011-10-29