Log In - Home Page

CommitFest 2011-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 30, Returned with Feedback: 16, Rejected: 6. Total: 52.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Environment checker to launch regression test
Patch by kaigai on 2011-07-25: Initial version.
Committed KaiGai Kohei Nobody 2011-07-25
lazy vxid locks
Review by jdavis on 2011-07-14: Patch looks good, awaiting results of performance discussion.
Patch by rhaas on 2011-07-20: v3
Review by jdavis on 2011-08-01: Minor questions.
Committed Robert Haas Jeff Davis 2011-08-04
per-column generic option
Patch by hanada on 2011-07-12: v4 patch, fixed some issues pointed by Alvaro.
Comment by aglio on 2011-07-15: Spec questions still under discussion.
Patch by hanada on 2011-07-29: v5 patch, just rebased against head.
Committed Shigeru Hanada Robert Haas 2011-08-05
vacuumlo: Avoid out of memory error by adding the option to complete after N unlinks.
Patch by timl on 2011-07-26: Initial version.
Patch by timl on 2011-08-07: minor code style changes pointed out by Josh and Aron.
Patch by timl on 2011-08-07: Josh adds bail out on PQTRANS_INERROR
Committed Timothy D. F. Lewis Josh Kupershmidt 2011-08-08
Autovacuum polling loop elimination, Latch in PGPROC
Patch by sternocera on 2011-08-04: Initial version.
Committed Peter Geoghegan Tom Lane 2011-08-10
psql: display of object comments
Patch by schmiddy on 2011-07-12: Initial version.
Patch by schmiddy on 2011-07-25: v2 of patch. This is a subset of the pg_comments patch consisting of just the changes to psql, which may be easier to review separately.
Comment by rhaas on 2011-08-08: Mostly committed, remaining bits attached.
Committed Josh Kupershmidt Robert Haas 2011-08-11
Idempotent script to adjust copyrights
Patch by dfetter on 2011-08-15: Initial version.
Committed David Fetter Nobody 2011-08-21
Change format of FDW options
Patch by hanada on 2011-08-18: put parentheses around non-NULL FDW options
Patch by hanada on 2011-08-24: quote option name with quote_ident().
Review by rhaas on 2011-08-31: Looks good, committed.
Committed Shigeru Hanada Robert Haas 2011-08-25
Fix problems about cascading replication
Patch by MasaoFujii on 2011-08-29: Initial version.
Committed Fujii Masao Nobody 2011-09-07
Buffering build for GiST indexes
Patch by smagen on 2011-08-15: Initial version.
Committed Alexander Korotkov Heikki Linnakangas 2011-09-11
don't check for page-level predicate locks on heap_insert
Patch by heikki on 2011-06-16: Initial version.
Review by jdavis on 2011-08-01: Minor comment about comment.
Committed Kevin Grittner Jeff Davis 2011-09-16
force_not_null support for file_fdw
Patch by hanada on 2011-09-05: Use elog() for internal error.
Patch by hanada on 2011-09-08: v4, Modify test data.
Patch by hanada on 2011-09-09: v5, Copy data from catalog cache before ReleaseSysCache().
Committed Shigeru Hanada KaiGai Kohei 2011-09-16
Database class support in contrib/sepgsql
Patch by kaigai on 2011-09-12: Initial version.
Review by rhaas on 2011-09-23: Committed.
Committed KaiGai Kohei Robert Haas 2011-09-23
new createuser option for replication role
Comment by c2main on 2011-09-22: comment feature behavior for superuser user and default behavior.
Patch by MasaoFujii on 2011-09-22: Updated patch per c2main's comment.
Review by rhaas on 2011-09-23: Committed. Should we make any changes in interactive mode?
Committed Fujii Masao Cédric Villemain 2011-09-23
memory barriers
Patch by rhaas on 2011-09-14: Initial version.
Patch by rhaas on 2011-09-23: v4
Committed Robert Haas Heikki Linnakangas, Kevin Grittner, Peter Geoghegan, Alvaro Herrera, Jeff Davis 2011-09-23
plpgsql: remove useless ccache searching when array is updated
Patch by okbobcz on 2011-06-20: Initial version.
Review by tgl on 2011-09-16: Crashes on record-field cases.
Patch by rhaas on 2011-09-23: v2 from Pavel
Committed Pavel Stehule Tom Lane 2011-09-26
EXPLAIN and nremoved
Review by marco44 on 2011-09-19: Review
Patch by tgl on 2011-09-22: My proposal ...
Comment by tgl on 2011-09-22: Patch per se is committed, but I'm leaving this open because we still need documentation changes.
Committed Marko Tiikkaja Marc Cousin 2011-09-28
Generate column names for subquery expressions
Review by horiguti on 2011-09-14: Seems good. Need document modification.
Patch by intgr on 2011-09-18: Version 3 to address review
Comment by horiguti on 2011-09-29: I've confirmed the fix.
Committed Marti Raudsepp Kyotaro Horiugchi 2011-10-01
Improve error handling in configuration files parser
Patch by alexk on 2011-08-03: v4, reworked per Tom Lane's suggestions. Patches from the former commit fest: https://commitfest.postgresql.org/action/patch_view?id=554
Review by AndyColson on 2011-09-08: can crash it
Patch by AndyColson on 2011-09-10: version 5
Committed Alexey Klyukin av 2011-10-02
Double sorting split for GiST
Patch by smagen on 2011-09-11: Initial version.
Patch by heikki on 2011-10-05: Latest patch
Committed Alexander Korotkov Heikki Linnakangas 2011-10-06
index-only scans
Patch by rhaas on 2011-09-14: Initial version.
Committed Robert Haas, Ibrar Ahmed Tom Lane 2011-10-08
Optimizing box_penalty
Patch by heikki on 2011-06-27: Initial version.
Patch by kgrittn on 2011-10-08: Reduced patch to portions which still seem relevant after other GiST changes. Seems like an improvement on clarity grounds, even though performance difference is now negligible. Marking "Ready for Committer".
Committed Heikki Linnakangas Kevin Grittner 2011-10-09
fix pg_dumpall to dump role config after all 'CREATE ROLE' statements
Patch by phils on 2011-10-12: Initial version.
Review by rhaas on 2011-10-12: Seems reasonable.
Committed Phil Sorber Tom Lane 2011-10-15
Log crashed backend's query (activity string)
Review by rhaas on 2011-10-19: avoid palloc, and some other nitpicking
Patch by intgr on 2011-10-21: Patch version 4 to address review by Robert Haas
Comment by rhaas on 2011-10-21: Committed, with crossed fingers.
Committed Marti Raudsepp PDXPUG, Robert Haas 2011-10-21
synchronized snapshots
Patch by jwieland on 2011-09-14: Initial version.
Review by jwieland on 2011-09-29: Marko's review
Patch by jwieland on 2011-09-29: 2nd version of the patch, addressing the issues Marko found
Committed Joachim Wieland Marko Tiikkaja 2011-10-22
Allow multiple Postgres clusters running on the same machine to distinguish themselves in the event log
Review by mha on 2011-07-14: Review
Patch by maumau on 2011-07-16: As I mentioned in the email, I integrated all modifications by Magnus. Thank you.
Comment by mha on 2011-10-25: Applied
Committed MauMau mha 2011-10-25
pg_receivexlog and background wal streaming for pg_basebackup
Patch by mha on 2011-08-16: Initial version.
Committed Magnus Hagander Jaime Casanova, Heikki Linnakangas 2011-10-26
Allow encoding specific character incrementer.
Patch by horiguti on 2011-10-18: Version 4 patch. add comment to increment functions and bug fix.
Review by rhaas on 2011-10-19: I think pg_utf8_increment() contains some bogus logic.
Comment by horiguti on 2011-10-29: I try to describe another aspect of this code.
Committed Kyotaro Horiguchi Robert Haas 2011-10-29
Separating bgwriter and checkpointer
Patch by guedes on 2011-10-04: Last updated patch
Review by gsmith on 2011-10-05: Initial review
Comment by tgl on 2011-10-24: Heikki's worried about whether fsync requests wouldn't make this a serious performance loss
Committed Simon Riggs Dickson Guedes 2011-11-02
Range Types
Patch by jdavis on 2011-10-16: Updated patch
Review by heikki on 2011-10-28: One (last?) outstanding with type caching here
Patch by jdavis on 2011-11-01: Addressed Heikki's review comments as well as Alexander Korotkov's suggestions.
Committed Jeff Davis Heikki Linnakangas 2011-11-03

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
savepoint commit performance
Patch by rhaas on 2011-07-18: Initial version.
Review by AndyColson on 2011-09-06: need update per Heikki
Returned with Feedback Simon Riggs Nobody 2011-09-06
Patch by ssinger on 2011-08-23: Initial version.
Comment by ssinger on 2011-09-13: Good suggestions from Robert and Alvaro. Will try pursue those ideas but and updated patch won't be ready in time for this commitfest.
Returned with Feedback Steve Singer Nobody 2011-09-13
Collect frequency statistics and selectivity estimation for arrays
Patch by smagen on 2011-06-14: Few more comments and some fixes
Review by aglio on 2011-07-15: Review from Nathan Boley
Comment by rhaas on 2011-09-21: Patch has not been updated in two months; issues from original review not addressed.
Returned with Feedback Alexander Korotkov Nathan Boley 2011-09-21
Cataloguing NOT NULL constraints
Patch by alvherre on 2011-07-22: updated version with pg_dump support and other cleanups
Comment by alvherre on 2011-09-14: Peter thinks this is entirely the wrong approach
Comment by kgrittn on 2011-09-26: Per Álvaro, not ready for review until major rewrite based on Peter's comments.
Returned with Feedback Álvaro Herrera Bernd Helmle 2011-09-26
regular logging of checkpoint progress
Patch by fuzzycz on 2011-09-02: Fixed comment, lower message priority (NOTICE instead of LOG)
Review by gsmith on 2011-09-19: Proposed changes with an enum based setting, making log verbosity more reasonable.
Comment by kgrittn on 2011-09-26: Author says he won't be able to submit reworked patch in time for this CF.
Returned with Feedback Tomas Vondra Greg Smith 2011-09-26
Single pass vacuum
Comment by AndyColson on 2011-09-07: patch needs rebased please
Patch by AndyColson on 2011-09-08: rebased
Review by rhaas on 2011-09-23: Worries about vacuum generation numbers, and MVCC catalog handling.
Returned with Feedback Pavan Deolasee Robert Haas 2011-10-10
Fix Leaky Views
Comment by rhaas on 2011-09-26: compiler warnings, fails regression tests, performance not acceptable
Patch by kaigai on 2011-09-28: Patch updated according to the above suggestions.
Review by rhaas on 2011-10-10: don't think this approach will work
Returned with Feedback KaiGai Kohei Robert Haas 2011-10-10
DROP statement reworks
Review by rhaas on 2011-10-10: compiler warnings
Comment by kaigai on 2011-10-11: Sorry, I didn't write out dependencies of the patches. Please apply in order of part-1, part-2 then part-3.
Review by rhaas on 2011-10-11: committed a few bits of this, rest needs substantial revision
Returned with Feedback KaiGai Kohei Dimitri Fontaine, Robert Haas 2011-10-11
Inserting heap tuples in bulk in COPY
Patch by heikki on 2011-09-14: Initial version.
Review by kaigai on 2011-09-26: review comments about heap_prepare_insert, CheckForSerializableConflictIn and volatile functions
Comment by rhaas on 2011-10-12: no update from author, marking returned with feedback
Returned with Feedback Heikki Linnakangas KaiGai Kohei 2011-10-12
Displaying accumulated autovacuum cost
Review by hanada on 2011-09-26: Basically fine, needs rebase.
Comment by gsmith on 2011-10-03: Should this report even when running non cost-based vacuums?
Comment by rhaas on 2011-10-12: no updated from author, marking returned with feedback
Returned with Feedback Noah Misch and Greg Smith Shigeru Hanada 2011-10-12
psql setenv command
Patch by kgrittn on 2011-09-19: Initial version.
Review by schmiddy on 2011-09-26: needs line in help.c, maybe tweak for WIN32?
Comment by rhaas on 2011-10-12: no update from author, marking returned with feedback
Returned with Feedback Andrew Dunstan Josh Kupershmidt, Jeff Janes 2011-10-12
pg_comments system view
Patch by schmiddy on 2011-09-13: Fix spurious doc change noticed by Thom Brown
Comment by rhaas on 2011-10-12: Do we want this?
Comment by rhaas on 2011-10-17: Apparently not very much.
Returned with Feedback Robert Haas, Josh Kupershmidt Lacey Powers 2011-10-17
WIP: Join push-down for foreign tables
Patch by hanada on 2011-09-15: Initial version.
Comment by kaigai on 2011-10-03: - An interface is necessary to inform the core supported features.
- The known issues might be a problem in pgsql_fdw side, not this patch itself.
Comment by rhaas on 2011-10-24: author will resubmit for next CF
Returned with Feedback Shigeru Hanada KaiGai Kohei 2011-10-24
cursor calling with named parameters
Patch by yhavinga on 2011-10-07: Updated patch
Review by royce on 2011-10-11: Seems good.
Review by tgl on 2011-10-15: Error reporting behavior needs much more work.
Returned with Feedback Yeb Havinga Royce Ausburn 2011-10-24
Online base backup from the hot-standby
Patch by Jun Ishizuka on 2011-10-19: updates to patch (fpw ver 7). change to the logic that fujii has suggested.
Patch by MasaoFujii on 2011-10-24: hopes this is the final version of the patch.
Review by heikki on 2011-10-26: This is too large a footgun. Let's make this work for pg_basebackup first.
Returned with Feedback Jun Ishizuka Steve Singer, Fujii Masao 2011-10-26
%TYPE and array declaration
Review by okbobcz on 2011-10-24: this is ready for commit
Patch by okbobcz on 2011-10-25: final Wojciech's patch,

regress tests are ok, no warnings
Review by tgl on 2011-10-28: I think this implementation is going in entirely the wrong direction.
Returned with Feedback Wojciech Muła <wojciech_mula@poczta.onet.pl> Pavel Stehule 2011-10-29

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Domains over composite types
Patch by heikki on 2011-06-24: Initial version.
Comment by yhavinga on 2011-07-14: The current version needs work: a domain composite type won't work from pl/pgsql.
Rejected Yeb Havinga Yeb Havinga 2011-07-25
Ignore lost+found when checking if a directory is empty
Patch by bdp on 2011-08-09: Initial version.
Comment by rhaas on 2011-09-14: Several votes against doing this, and no votes in favor, so marking rejected.
Rejected Brian Pitts Nobody 2011-09-14
Optimizing pg_trgm makesign()
Comment by kgrittn on 2011-09-26: Tom expresses concern about performance of Heikki's patch on 32-bit systems, and expresses concern about changes to HASH macros.
Review by kgrittn on 2011-09-29: Tom's 1st patch improves on Heikki's first patch. Tom's 2nd patch erases performance gain for actual English text. Heikki's 2nd patch crashes on 32-bit compiles. Can either 2nd patch be salvaged?
Comment by tgl on 2011-10-01: Heikki's later idea (eliminate all the redundant calls of makesign) pretty much obsoletes this idea.
Rejected Heikki Linnakangas Kevin Grittner 2011-10-01
fix pg_dumpall to dump role config and database config at the end of dump
Comment by tgl on 2011-09-04: Before accepting this we need to think about the consequences for settings such as dynamic_library_path.
Review by rhaas on 2011-10-10: Tom's concerns seem valid, but why not just RESET ROLE?
Comment by phils on 2011-10-12: Rejecting my own patch.
Rejected Phil Sorber Nobody 2011-10-10
Object access hook with arguments
Patch by kaigai on 2011-08-28: Initial version.
Patch by kaigai on 2011-09-29: Patch updated
Review by rhaas on 2011-10-12: This approach seems unacceptable.
Rejected KaiGai Kohei Robert Haas 2011-10-12
prepare plans of embedded sql on function start
Comment by tgl on 2011-09-17: I think we'd be better off seeing this as an extension to the capabilities of VALIDATOR functions, and driven by some explicit CHECK request, not automatically during any function call.
Patch by tgl on 2011-10-06: Updated patch using CHECK syntax
Comment by tgl on 2011-10-29: Original approach is considered rejected. New patch requires a new review, so I entered it in 2011-11 commitfest.
Rejected Pavel Stehule Tom Lane 2011-10-29