Log In - Home Page

CommitFest 2011-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Committed".

Status Summary. Committed: 29, Returned with Feedback: 29, Rejected: 1. Total: 59.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Binary in/out for void
Patch by rsmogura on 2011-02-21: Initial version.
Committed Radosław Smogura Nobody 2011-02-22
PL/Python tracebacks
Patch by wulczer on 2011-03-03: Tracebacks now in errcontext.
Patch by tgl on 2011-03-07: Patch split into 3 parts that address slightly distinct issues.
Comment by wulczer on 2011-03-20: New version with the remaining part revamped.
Committed Jan Urbański Alex Hunsaker 2011-04-06
missing tab completions for COMMENT ON
Patch by schmiddy on 2011-05-29: Initial version.
Review by rhaas on 2011-06-12: Committed and back-patched to 9.1 (with some changes)
Committed Josh Kupershmidt Robert Haas 2011-06-12
Use symbolic constants when indexing arrays instead of i++
Patch by rhpostgres on 2011-06-14: Initial version.
Review by fgp on 2011-06-16: Patch looks good and passes "make check". Marking as Ready for Committer.
Committed Richard Hopkins Florian Pflug 2011-06-16
pg_hba.conf field-specific keywords
Patch by direvus on 2011-06-17: v2 of patch, updated to HEAD.
Patch by alvherre on 2011-06-21: v3
Comment by okbobcz on 2011-06-27: processing of load_ident is different than load_hba
Committed Brendan Jurd Pavel Stehule, Álvaro Herrera 2011-06-20
Eliding no-op varchar length coercions
Patch by nmisch on 2011-06-11: v2
Review by rhaas on 2011-06-19: Could use a few more comments, but otherwise looks good to me.
Patch by nmisch on 2011-06-19: v3
Committed Noah Misch Robert Haas, Alexey Klyukin 2011-06-22
deadlock_timeout at PGC_SUSET
Patch by nmisch on 2011-06-11: Initial version.
Review by hanada on 2011-06-17: Seems fine, marked as "Ready for committer"
Committed Noah Misch Shigeru Hanada 2011-06-22
smallserial / serial2 support
Patch by mikepultz on 2011-06-08: Updated patch including documentation
Review by brar on 2011-06-08: Everything seems fine so far. We probably need some more agreement on whether this is useful/necessary and a quick re-review from a more experienced person than me.
Committed Mike Pultz Brar Piening 2011-06-22
crash-safe visibility map
Patch by nmisch on 2011-06-19: v6 from rhaas
Review by nmisch on 2011-06-19: patch has some bogus hunks, but otherwise ready
Patch by nmisch on 2011-06-20: v7 from rhaas - extra hunks removed
Committed Robert Haas Noah Misch 2011-06-22
heap_hot_search_buffer refactoring
Patch by rhaas on 2011-06-06: Initial version.
Review by jdavis on 2011-06-25: Bug
Review by jdavis on 2011-06-25: Review
Committed Robert Haas based on a patch by Heikki Linnakanagas Jeff Davis 2011-06-27
use less space in xl_xact_commit
Patch by leonardof on 2011-05-19: Initial version.
Patch by leonardof on 2011-05-25: Fixed some English mistakes
Patch by leonardof on 2011-06-15: New patch, based on Simon Riggs suggestion
Committed Leonardo Francalanci Simon Riggs 2011-06-28
DROP Reworks Part.0 - missing_ok support on get_object_address
Patch by kaigai on 2011-06-19: Patch revised. (v3)
Review by rhaas on 2011-06-22: Gripes about locking.
Patch by kaigai on 2011-06-23: Patch revised. (v4)
Committed KaiGai Kohei Robert Haas 2011-06-28
CHECK constraints with NOT VALID
Patch by alvherre on 2011-06-01: Initial version.
Patch by alvherre on 2011-06-16: Updated patch
Comment by jcasanov on 2011-06-18: Reviewed by Thom Brown and Jaime Casanova. Currently the patch compiles and works as expected... besides a few comments about the docs everything looks ok.
Committed Álvaro Herrera Jaime Casanova 2011-06-30
psql include files using relative paths
Review by schmiddy on 2011-05-28: Review of the third version.
Patch by singh.gurjeet on 2011-06-05: Newer version of the patch submitted, with review comments incorporated.
Patch by singh.gurjeet on 2011-06-06: Minor C code comment improvements.
Committed Gurjeet Singh Josh Kupershmidt 2011-07-06
standardize queries in describe.c
Patch by schmiddy on 2011-05-13: Initial version.
Review by merlinm on 2011-06-14: Brought patch up to HEAD. Looks good -- can commit as-is, but author should justify putting semi-colons in each query vs the print function. Marked waiting on author.
Comment by merlinm on 2011-06-16: Given lack of comment, decided to push patch as is...
Committed Josh Kupershmidt Merlin Moncure 2011-07-06
Latch implementation: wake on postmaster death, reduce archiver wakeups
Patch by sternocera on 2011-06-22: New patch that addresses Fujii's second, more recent set of concerns
Patch by sternocera on 2011-06-25: Patch that addresses Fujii's third and most recent set of concerns.
Comment by MasaoFujii on 2011-06-30: Further comments
Committed Peter Geoghegan Heikki Linnakangas, Fujii Masao 2011-07-08
Make relation_openrv atomic wrt DDL
Review by rhaas on 2011-07-06: Review.
Patch by rhaas on 2011-07-07: Hack, hack.
Review by nmisch on 2011-07-07: rhaas version seems sound; cosmetic points
Committed Noah Misch Greg Stark, Robert Haas 2011-07-09
Move childoffnum to child in GISTInsertStack
Patch by smagen on 2011-05-24: Initial version.
Comment by aglio on 2011-07-14: Patch needs further revision to be safe per discussion. Deferring.
Committed Alexander Korotkov Jeff Janes, Heikki Linnakangas 2011-07-14
Add ability to constrain backend temporary file space
Patch by c2main on 2011-06-15: updated patch from Mark
Review by c2main on 2011-06-20: review (except performance review) + updated patch with a fix and cosmetic changes.
Patch by aglio on 2011-06-27: Updated patch version
Committed Mark Kirkwood Tatsuo Ishii 2011-07-17
reduce overhead of frequent table locks
Patch by rhaas on 2011-06-12: v3. Fixed GetLockConflicts(). Other minor fixes. Discussion of remaining issues.
Patch by rhaas on 2011-06-27: v4. Fixed pg_locks, removed debugging code, a bit of renaming.
Review by jdavis on 2011-07-12: Looks good!
Committed Robert Haas Jeff Davis 2011-07-18
Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE
Review by rhaas on 2011-07-06: doesn't seem to compile?
Patch by nmisch on 2011-07-06: v4
Review by rhaas on 2011-07-07: Looks good, with minor caveats. Marking Ready for Committer.
Committed Noah Misch Robert Haas 2011-07-18
enhanced diagnostics
Patch by okbobcz on 2011-07-07: fixed issues, merge with Hanada's patch
Review by theory on 2011-07-10: Looks good, just tweaked the documentation in a new patch.
Patch by okbobcz on 2011-07-15: final patch
Committed Pavel Stehule David Wheeler 2011-07-18
savepoint commit performance
Patch by rhaas on 2011-02-24: Initial version.
Review by heikki on 2011-06-06: Needs some fixing
Committed Simon Riggs Heikki Linnakangas 2011-07-19
Cascade Replication
Patch by MasaoFujii on 2011-07-05: Updated version; simplify the patch to focus on the main problem.
Comment by MasaoFujii on 2011-07-11: Simon's another comments.
Patch by MasaoFujii on 2011-07-11: Updated version; addressed all the issues raised by Simon.
Committed Fujii Masao Simon Riggs 2011-07-19
security label of shared object
Patch by kaigai on 2011-07-02: pg_shseclabel.provider was re-defined as NameData, instead of Text
Patch by kaigai on 2011-07-06: Toast table & index removed (v5)
Comment by rhaas on 2011-07-20: committed... mostly
Committed KaiGai Kohei Joe Conway, Robert Haas 2011-07-20
XML error handling improvement to fix XPATH bug
Patch by fgp on 2011-06-22: Made to work libxml 2.6.23 and 2.7.8 and fixes all but two of Noah's complains. These two are still being discussed.
Review by nmisch on 2011-06-24: New version achieves goals. Further discussion, minor code notes
Patch by nmisch on 2011-06-27: Cosmetic revisions; looks good
Committed Florian Pflug Noah Misch 2011-07-20
Bugfix for XPATH() if expression returns a scalar value
Patch by fgp on 2011-06-09: Rebased onto HEAD
Review by fgp on 2011-06-29: Radoslaw thinks the patch is fine, expect for the escaping of the return values, even though that will create values of type XML which are not well-formed.
Review by rsmogura on 2011-07-14: I like scalars, I don't like escaping, according to others escaping is ok. My objections to escaping are as follow:
- possibility of double escaping
- problems with de-escaping this on client side
- this patch doens't resolves all mentioned problems about inserting wrong XMLs, if we are going in this mentioned spirit the result of text node must not only be escaped, but wrapped by any kind of root element
- backward compatibility problems
- when I ask for text() I want to extract text not a XML, if I want to get node I will ask /* not a text(/*)
- if user recreates XML which is serialized as text in some node, after patch he will insert improper XMLs, because he will get escaped text - no root element.
Committed Florian Pflug Radosław Smogura 2011-07-21
Bugfix for XPATH() if text or attribute nodes are selected
Review by fgp on 2011-06-29: Radoslaw believes that the current behaviour is per design, even though it creates instances of type XML which are not well-formed.
Review by rsmogura on 2011-07-14: Peter Eisentraut is up for this so I bump it up. My objections was:
- possibility of double escaping
- problems with de-escaping this on client side
- this patch doens't resolves all mentioned problems about inserting wrong XMLs, if we are going in this mentioned spirit the result of text node must not only be escaped, but wrapped by any kind of root element
- backward compatibility problems
- if user recreates XML which is serialized as text in some node, after patch he will insert improper XMLs, because he will get escaped text - no root element.
- when I ask for text() I want to extract text not a XML, if I want to get node I will ask /* not a text(/*)
Comment by aglio on 2011-07-14: Ready to go, per Radoslaw.
Committed Florian Pflug Radosław Smogura 2011-07-21
Bugfix for libpq's PQsetvalue
Patch by pasha_golub on 2011-07-18: Initial version.
Comment by pasha_golub on 2011-07-18: Merlin Moncure wrote about this bug and about my proposal about adding PQdeleteTupple
Comment by merlinm on 2011-07-18: this bug goes back to 9.0 (calling PQsetvalue will crash the client if you call it on a result returned from a query)
Committed Andrew Chernow Robert Haas 2011-07-21